Return-path: Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:21299 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853Ab3IYXNm convert rfc822-to-8bit (ORCPT ); Wed, 25 Sep 2013 19:13:42 -0400 From: Bing Zhao To: Joe Perches , "netdev@vger.kernel.org" CC: "David S. Miller" , "John W. Linville" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 25 Sep 2013 16:13:32 -0700 Subject: RE: [PATCH 09/11] mwifiex: Remove extern from function prototypes Message-ID: <477F20668A386D41ADCC57781B1F70430F45077E54@SC-VEXCH1.marvell.com> (sfid-20130926_011346_278082_37472DDB) References: In-Reply-To: Content-Type: text/plain; charset=US-ASCII MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Joe, Thanks for your patch. > There are a mix of function prototypes with and without extern > in the kernel sources. Standardize on not using extern for > function prototypes. > > Function prototypes don't need to be written with extern. > extern is assumed by the compiler. Its use is as unnecessary as > using auto to declare automatic/local variables in a block. > > Signed-off-by: Joe Perches Acked-by: Bing Zhao Thanks, Bing > --- > drivers/net/wireless/mwifiex/wmm.h | 24 ++++++++++-------------- > 1 file changed, 10 insertions(+), 14 deletions(-)