Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:60693 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965Ab3ITBVs (ORCPT ); Thu, 19 Sep 2013 21:21:48 -0400 Message-ID: <1379640097.2500.4.camel@bwh-desktop.uk.level5networks.com> (sfid-20130920_032238_800718_606270B5) Subject: Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks From: Ben Hutchings To: Russell King CC: , , , , , , , , , , , , , , , , , , , , , , "Solarflare linux maintainers" , , Rob Landley , Vinod Koul , Dan Williams Date: Fri, 20 Sep 2013 02:21:37 +0100 In-Reply-To: References: <20130919212235.GD12758@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2013-09-19 at 22:25 +0100, Russell King wrote: > Provide a helper to set both the DMA and coherent DMA masks to the > same value - this avoids duplicated code in a number of drivers, > sometimes with buggy error handling, and also allows us identify > which drivers do things differently. > > Signed-off-by: Russell King > --- > Documentation/DMA-API-HOWTO.txt | 37 ++++++++++++++++++++++--------------- > Documentation/DMA-API.txt | 8 ++++++++ > include/linux/dma-mapping.h | 14 ++++++++++++++ > 3 files changed, 44 insertions(+), 15 deletions(-) > > diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt > index 14129f1..5e98303 100644 > --- a/Documentation/DMA-API-HOWTO.txt > +++ b/Documentation/DMA-API-HOWTO.txt [...] > -dma_set_coherent_mask() will always be able to set the same or a > -smaller mask as dma_set_mask(). However for the rare case that a > +The coherent coherent mask will always be able to set the same or a > +smaller mask as the streaming mask. However for the rare case that a [...] The new wording doesn't make sense; a mask doesn't set itself. I would suggest: "The coherent mask can always be set to the same or a smaller mask than the streaming mask." Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.