Message-ID: <1380532248.14467.4.camel@jlt4.sipsolutions.net> (sfid-20130930_111055_331632_55D8E593)
Subject: Re: [PATCH 3.12 2/2] mac80211: update sta->last_rx on acked tx
 frames
From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Date: Mon, 30 Sep 2013 11:10:48 +0200
In-Reply-To: <1380483574-88667-2-git-send-email-nbd@openwrt.org>
References: <1380483574-88667-1-git-send-email-nbd@openwrt.org>
	 <1380483574-88667-2-git-send-email-nbd@openwrt.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Sun, 2013-09-29 at 21:39 +0200, Felix Fietkau wrote:
> When clients are idle for too long, hostapd sends nullfunc frames for
> probing. When those are acked by the client, the idle time needs to be
> updated.
> 
> To make this work (and to avoid unnecessary probing), update sta->last_rx
> whenever an ACK was received for a tx packet. Only do this if the flag
> IEEE80211_HW_REPORTS_TX_ACK_STATUS is set.

Why that last bit? If we got an ack status, wouldn't it be OK to do
either way? Or are you saying drivers are lying more often than not
otherwise?

johannes