Return-path: Received: from mail-la0-f46.google.com ([209.85.215.46]:56842 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422Ab3IVT4o (ORCPT ); Sun, 22 Sep 2013 15:56:44 -0400 Received: by mail-la0-f46.google.com with SMTP id eh20so1863650lab.33 for ; Sun, 22 Sep 2013 12:56:42 -0700 (PDT) Message-ID: <523F4B76.80507@cogentembedded.com> (sfid-20130922_215651_088774_DE71F060) Date: Sun, 22 Sep 2013 23:56:38 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Peter Senna Tschudin CC: Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn, joe@perches.com, linville@tuxdriver.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH V2] wireless: rtlwifi: Replace variable with a brake References: <1379879410-22787-1-git-send-email-peter.senna@gmail.com> In-Reply-To: <1379879410-22787-1-git-send-email-peter.senna@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 09/22/2013 11:50 PM, Peter Senna Tschudin wrote: You have a typo in the subject -- "brake" is a device to stop a vehicle. :-) > This patch removes the variable continual, and change the while loop > to break when efuse_data == 0xFF. > Tested by compilation only. > CC: Joe Perches > Signed-off-by: Peter Senna Tschudin > --- > Changes from V1: > - Fix the indetation > - Remove remaining } from removed else > Please ignore the patch: > [PATCH 12/19] wireless: Change variable type to bool > And apply this one instead. > The variable continual was declared as int, but was used as bool. I > sent previous patch changing the variable type to bool, but Joe Perches > proposed that removing the variable and adding a brake would be better. > drivers/net/wireless/rtlwifi/efuse.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > diff --git a/drivers/net/wireless/rtlwifi/efuse.c b/drivers/net/wireless/rtlwifi/efuse.c > index 838a1ed..2aedd9f 100644 > --- a/drivers/net/wireless/rtlwifi/efuse.c > +++ b/drivers/net/wireless/rtlwifi/efuse.c > @@ -1203,20 +1203,18 @@ static void efuse_power_switch(struct ieee80211_hw *hw, u8 write, u8 pwrstate) > > static u16 efuse_get_current_size(struct ieee80211_hw *hw) > { > - int continual = true; > u16 efuse_addr = 0; > u8 hworden; > u8 efuse_data, word_cnts; > > - while (continual && efuse_one_byte_read(hw, efuse_addr, &efuse_data) > - && (efuse_addr < EFUSE_MAX_SIZE)) { > - if (efuse_data != 0xFF) { > - hworden = efuse_data & 0x0F; > - word_cnts = efuse_calculate_word_cnts(hworden); > - efuse_addr = efuse_addr + (word_cnts * 2) + 1; > - } else { > - continual = false; > - } > + while (efuse_one_byte_read(hw, efuse_addr, &efuse_data) && > + (efuse_addr < EFUSE_MAX_SIZE)) { Start this line under efuse_one_byte_read, please. Also, parens are not needed. WBR, Sergei