Return-path: Received: from mail-ie0-f176.google.com ([209.85.223.176]:45553 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797Ab3IKID5 (ORCPT ); Wed, 11 Sep 2013 04:03:57 -0400 Received: by mail-ie0-f176.google.com with SMTP id w15so2654357iea.7 for ; Wed, 11 Sep 2013 01:03:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1378841057.4223.38.camel@porter.coelho.fi> References: <1378218848-7853-1-git-send-email-eliad@wizery.com> <1378218848-7853-3-git-send-email-eliad@wizery.com> <1378794898.4799.37.camel@porter.coelho.fi> <1378841057.4223.38.camel@porter.coelho.fi> Date: Wed, 11 Sep 2013 10:03:55 +0200 Message-ID: (sfid-20130911_100405_242419_DF7A0FE5) Subject: Re: [PATCH 03/12] wlcore: disable elp sleep while in plt mode From: Eliad Peller To: Luca Coelho Cc: "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Sep 10, 2013 at 10:24 PM, Luca Coelho wrote: > On Tue, 2013-09-10 at 16:04 +0200, Eliad Peller wrote: >> On Tue, Sep 10, 2013 at 9:34 AM, Luca Coelho wrote: >> > On Tue, 2013-09-03 at 17:33 +0300, Eliad Peller wrote: >> >> From: Yair Shapira >> >> >> >> We now disable elp sleep during plt mode to allow normal operation of >> >> plt tools such as calibrator. >> >> >> >> Having elp_sleep enabled during plt mode is actually not required and >> >> in fact it disrupt plt operations such as rx statistics etc. >> >> >> >> Signed-off-by: Yair Shapira >> >> Signed-off-by: Eliad Peller >> >> --- >> > >> > I also had a comment internally about this one. Why do we need this? >> > AFAICT this would never happen in real life, since the firmware is not >> > even loaded at this point. Is there any real life situation where we >> > try to go into ELP while in PLT mode? >> > >> i'm not familiar with the whole plt process, but i guess some flows >> might indeed end up in elp (e.g. via wl1271_cmd_interrogate(), in >> order to read statistics) > > Well, I don't think this would ever happen. The PLT stuff is a > completely different firmware and, really, if it tries to go into ELP > mode it is a bug. > i can see the calibrator calls various WL1271_TM_CMD_TEST commands, so i guess they are likely to end up with ps_elp_sleep() calls (in wl1271_tm_cmd_test()). Eliad.