Return-path: Received: from mail-vc0-f182.google.com ([209.85.220.182]:45488 "EHLO mail-vc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015Ab3IRT7h (ORCPT ); Wed, 18 Sep 2013 15:59:37 -0400 From: Larry Finger To: linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, Larry Finger , netdev@vger.kernel.org, Stable Subject: [PATCH 7/8 V3] rtlwifi: rtl8188ee: Fix smatch warning in rtl8188ee/hw.c Date: Wed, 18 Sep 2013 14:58:58 -0500 Message-Id: <1379534339-14895-8-git-send-email-Larry.Finger@lwfinger.net> (sfid-20130918_215945_923770_73C4D6D5) In-Reply-To: <1379534339-14895-5-git-send-email-Larry.Finger@lwfinger.net> References: <1379534339-14895-5-git-send-email-Larry.Finger@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: Smatch lists the following: CHECK drivers/net/wireless/rtlwifi/rtl8188ee/hw.c drivers/net/wireless/rtlwifi/rtl8188ee/hw.c:149 _rtl88ee_set_fw_clock_on() info: ignoring unreachable code. drivers/net/wireless/rtlwifi/rtl8188ee/hw.c:149 _rtl88ee_set_fw_clock_on() info: ignoring unreachable code. This info message is the result of a real error due to a missing break statement in a "while (1)" loop. Signed-off-by: Larry Finger Cc: Stable [3.10+] --- drivers/net/wireless/rtlwifi/rtl8188ee/hw.c | 1 + 1 file changed, 1 insertion(+) Index: wireless-testing-save/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c =================================================================== --- wireless-testing-save.orig/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c +++ wireless-testing-save/drivers/net/wireless/rtlwifi/rtl8188ee/hw.c @@ -143,6 +143,7 @@ static void _rtl88ee_set_fw_clock_on(str } else { rtlhal->fw_clk_change_in_progress = false; spin_unlock_bh(&rtlpriv->locks.fw_ps_lock); + break; } }