Return-path: Received: from mail-oa0-f41.google.com ([209.85.219.41]:59839 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513Ab3IMRpW (ORCPT ); Fri, 13 Sep 2013 13:45:22 -0400 From: Larry Finger To: linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, Larry Finger , netdev@vger.kernel.org Subject: [PATCH 5/7: rtlwifi: Fix smatch warning in pci.c Date: Fri, 13 Sep 2013 12:45:02 -0500 Message-Id: <1379094304-22041-6-git-send-email-Larry.Finger@lwfinger.net> (sfid-20130913_194541_556712_4764FE20) In-Reply-To: <1379094304-22041-1-git-send-email-Larry.Finger@lwfinger.net> References: <1379094304-22041-1-git-send-email-Larry.Finger@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: Smatch reports the following: CHECK drivers/net/wireless/rtlwifi/pci.c drivers/net/wireless/rtlwifi/pci.c:739 _rtl_pci_rx_interrupt() warn: assigning (-98) to unsigned variable 'stats.noise' This problem is fixed by changing the value to 256 - 98. Signed-off-by: Larry Finger --- drivers/net/wireless/rtlwifi/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c index 703f839..bf498f5 100644 --- a/drivers/net/wireless/rtlwifi/pci.c +++ b/drivers/net/wireless/rtlwifi/pci.c @@ -736,7 +736,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw) struct rtl_stats stats = { .signal = 0, - .noise = -98, + .noise = 158, /* -98 dBm */ .rate = 0, }; int index = rtlpci->rx_ring[rx_queue_idx].idx; -- 1.8.1.4