Return-path: Received: from mail-bk0-f54.google.com ([209.85.214.54]:63047 "EHLO mail-bk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987Ab3IHGUq (ORCPT ); Sun, 8 Sep 2013 02:20:46 -0400 Received: by mail-bk0-f54.google.com with SMTP id mz12so1866798bkb.13 for ; Sat, 07 Sep 2013 23:20:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1378408479-1025-1-git-send-email-yeohchunyeow@cozybit.com> References: <1378408479-1025-1-git-send-email-yeohchunyeow@cozybit.com> From: Thomas Pedersen Date: Sat, 7 Sep 2013 23:20:25 -0700 Message-ID: (sfid-20130908_082049_943911_3CF97E27) Subject: Re: [PATCH v2] mac80211: fix the setting of extended supported rate IE To: Chun-Yeow Yeoh Cc: linux-wireless , Johannes Berg , John Linville , open11s , "distro11s@cozybit.com" , Colleen Twitty Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Sep 5, 2013 at 12:14 PM, Chun-Yeow Yeoh wrote: > The patch "mac80211: select and adjust bitrates according to > channel mode" causes regression and breaks the extended supported rate > IE setting. Since "i" is starting with 8, so this is not necessary > to introduce "skip" here. > > Signed-off-by: Chun-Yeow Yeoh > Signed-off-by: Colleen Twitty > Reviewed-by: Jason Abele > --- > v2: remove skip (Jason) > > net/mac80211/util.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/net/mac80211/util.c b/net/mac80211/util.c > index 3c8283b..4bb639f 100644 > --- a/net/mac80211/util.c > +++ b/net/mac80211/util.c > @@ -2128,14 +2128,11 @@ int ieee80211_add_ext_srates_ie(struct ieee80211_sub_if_data *sdata, > pos = skb_put(skb, exrates + 2); > *pos++ = WLAN_EID_EXT_SUPP_RATES; > *pos++ = exrates; > - skip = 0; You could also remove the declaration then? -- Thomas