Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:29297 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754736Ab3IEFIU (ORCPT ); Thu, 5 Sep 2013 01:08:20 -0400 From: Kalle Valo To: Julian Calaby CC: "Luis R. Rodriguez" , linux-wireless Subject: Re: [PATCH 2/2] qca-swiss-army-knife: add ath10k trace-cmd plugin References: <1376939466-8282-1-git-send-email-kvalo@qca.qualcomm.com> <1376939466-8282-2-git-send-email-kvalo@qca.qualcomm.com> <871u53swie.fsf@kamboji.qca.qualcomm.com> Date: Thu, 5 Sep 2013 08:08:14 +0300 In-Reply-To: (Julian Calaby's message of "Thu, 5 Sep 2013 14:57:35 +1000") Message-ID: <87ob87rh35.fsf@kamboji.qca.qualcomm.com> (sfid-20130905_070823_240496_7FFA0090) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Julian, Julian Calaby writes: > On Thu, Sep 5, 2013 at 2:49 PM, Kalle Valo wrote: >> "Luis R. Rodriguez" writes: >> >>> On Mon, Aug 19, 2013 at 12:11 PM, Kalle Valo wrote: >>>> This one's a skeleton as well. >>>> >>>> Signed-off-by: Kalle Valo >>> >>> Applied both and pushed, thanks! >> >> Thanks. >> >>> I just removed 3 trailing spaces on the 2 patches. One had two >>> trailing spaces, the last patch had one. >> >> Oh, sorry about that. Any ideas how I could check for those myself? > > If you have coloured diff output enabled in git (color.diff = true) > then they and other whitespace errors are highlighted in red whenever > you do diffs. I don't normally have colors enabled (don't like them), but it seems to be easy to enable with 'git diff --color'. It's just that it doesn't seem to work in my terminal, I only see the ANSI codes and no colors. But this is the best way to do that, just need to fix my terminal. Thanks! -- Kalle Valo