Return-path: Received: from mail-ie0-f175.google.com ([209.85.223.175]:65349 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757Ab3IJNqx (ORCPT ); Tue, 10 Sep 2013 09:46:53 -0400 Received: by mail-ie0-f175.google.com with SMTP id 9so1876413iec.34 for ; Tue, 10 Sep 2013 06:46:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1378796198.4799.49.camel@porter.coelho.fi> References: <1378218848-7853-1-git-send-email-eliad@wizery.com> <1378218848-7853-2-git-send-email-eliad@wizery.com> <1378794813.4799.35.camel@porter.coelho.fi> <1378796198.4799.49.camel@porter.coelho.fi> Date: Tue, 10 Sep 2013 15:46:50 +0200 Message-ID: (sfid-20130910_154656_150493_74F90A33) Subject: Re: [PATCH 02/12] wlcore: add new plt power-mode: CHIP_AWAKE From: Eliad Peller To: Luca Coelho Cc: Arik Nemtsov , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Sep 10, 2013 at 9:56 AM, Luca Coelho wrote: > On Tue, 2013-09-10 at 08:47 +0200, Arik Nemtsov wrote: >> On Tue, Sep 10, 2013 at 9:33 AM, Luca Coelho wrote: >> > On Tue, 2013-09-03 at 17:33 +0300, Eliad Peller wrote: >> >> From: Yair Shapira >> >> >> >> Under this mode the chip is powered on including sdio >> >> but no FW is downloaded and run, interrupts are not enabled, etc... >> >> >> >> This mode is intended to allow RTTT to bridge sdio as a transport >> >> to the chip. >> >> >> >> Driver only provides sdio access using the dev_mem debugfs file. >> >> >> >> Some fixes done to the code that ensures that PLT mode and normal >> >> driver power mode (ifconfig/add_interface) are mutually excluded. >> >> >> >> Signed-off-by: Yair Shapira >> >> Signed-off-by: Eliad Peller >> >> --- >> > >> > I had some comments to this patch internally while I was still at TI. >> > Namely, I asked why do we need a new way of doing this if this is >> > already possible via debugsfs (using the gpio_power file)? >> >> Are you commenting on the correct patch? Seems this is just a patch to >> prevent "ifconfig up" during PLT mode.. > > Yes, I'm commenting on the right patch. It allows the chip power > (namely the WLAN_EN GPIO pin) to be set directly, without loading the > firmware and doing other initialization stuff. This can already be > controlled via the gpio_power debugfs file. I've used that a bunch of > times, including with the RTTT tool. > > Okay, this patch has a few more protections (eg. not allowing an > interface to be added while the chip is powered in this way), but this > could also be added on top of the existing implementation. > i guess this just a bit "cleaner" (similar to the way PLT is used). the gpio_power debugfs only toggles the gpio power, without changing the driver mode, so adding similar protections will be more complicated. Eliad.