Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:29894 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753313Ab3IZHaO (ORCPT ); Thu, 26 Sep 2013 03:30:14 -0400 Cc: , , Jouni Malinen , "Luis R. Rodriguez" , , "John W. Linville" , , "David S. Miller" , From: Kalle Valo To: Joe Perches Subject: Re: [PATCH 04/11] ath: Remove extern from function prototypes References: Date: Thu, 26 Sep 2013 10:30:00 +0300 In-Reply-To: (Joe Perches's message of "Wed, 25 Sep 2013 12:37:22 -0700") Message-ID: <871u4ct4zr.fsf@kamboji.qca.qualcomm.com> (sfid-20130926_093039_378319_85A20AD5) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Joe Perches writes: > There are a mix of function prototypes with and without extern > in the kernel sources. Standardize on not using extern for > function prototypes. > > Function prototypes don't need to be written with extern. > extern is assumed by the compiler. Its use is as unnecessary as > using auto to declare automatic/local variables in a block. > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/ath/ath10k/debug.h | 8 ++++---- > drivers/net/wireless/ath/ath6kl/common.h | 3 +-- > drivers/net/wireless/ath/ath6kl/debug.h | 9 ++++----- > drivers/net/wireless/ath/ath9k/ath9k.h | 2 +- > 4 files changed, 10 insertions(+), 12 deletions(-) For the ath10k and ath6kl changes: Acked-by: Kalle Valo -- Kalle Valo