Return-path: Received: from mail.ispras.ru ([83.149.199.45]:40980 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090Ab3I1FQZ (ORCPT ); Sat, 28 Sep 2013 01:16:25 -0400 Message-ID: <52466624.4040106@ispras.ru> (sfid-20130928_071708_738370_E8DA216D) Date: Sat, 28 Sep 2013 01:16:20 -0400 From: Alexey Khoroshilov MIME-Version: 1.0 To: Fabio Estevam CC: Christian Lamparter , "John W. Linville" , linux-wireless@vger.kernel.org, "netdev@vger.kernel.org" , linux-kernel , ldv-project@linuxtesting.org Subject: Re: [PATCH] carl9170: fix leaks at failure path in carl9170_usb_probe() References: <1380340311-4630-1-git-send-email-khoroshilov@ispras.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 28.09.2013 00:17, Fabio Estevam wrote: > On Sat, Sep 28, 2013 at 12:51 AM, Alexey Khoroshilov > wrote: > >> - return request_firmware_nowait(THIS_MODULE, 1, CARL9170FW_NAME, >> + err = request_firmware_nowait(THIS_MODULE, 1, CARL9170FW_NAME, >> &ar->udev->dev, GFP_KERNEL, ar, carl9170_usb_firmware_step2); >> + if (err) { >> + usb_put_dev(udev); >> + usb_put_dev(udev); > You are doing the same free twice. Yes, because it was get twice. > I guess you meant to also free: usb_put_dev(ar->udev) udev and ar->udev are equal, so technically the patch is correct. I agree that there is some inconsistency, but I would prefer to fix it at usb_get_dev() side with a comment about reasons for the double get. -- Alexey