Return-path: Received: from ring0.de ([91.143.88.219]:59764 "EHLO smtp.ring0.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397Ab3J0UMf (ORCPT ); Sun, 27 Oct 2013 16:12:35 -0400 Date: Sun, 27 Oct 2013 21:12:20 +0100 From: Sebastian Reichel To: Alexander Shiyan Cc: Luciano Coelho , Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , Tony Lindgren , Greg Kroah-Hartman , Stephen Warren , linux-doc@vger.kernel.org, "John W. Linville" , Rob Herring , linux-kernel@vger.kernel.org, Sachin Kamat , Bill Pemberton , Felipe Balbi , Rob Landley , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver Message-ID: <20131027201218.GA4414@earth.universe> (sfid-20131027_211301_971688_514A8E4D) References: <1382890469-25286-1-git-send-email-sre@debian.org> <1382890469-25286-3-git-send-email-sre@debian.org> <1382891056.102746625@f315.i.mail.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" In-Reply-To: <1382891056.102746625@f315.i.mail.ru> Sender: linux-wireless-owner@vger.kernel.org List-ID: --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 27, 2013 at 08:24:16PM +0400, Alexander Shiyan wrote: > > Move the power GPIO handling from the board code into > > the driver. This is a dependency for device tree support. > >=20 > > Signed-off-by: Sebastian Reichel > > --- > > arch/arm/mach-omap2/board-omap3pandora.c | 2 ++ > > arch/arm/mach-omap2/board-rx51-peripherals.c | 11 ++-------- > > drivers/net/wireless/ti/wl1251/sdio.c | 21 +++++++++++++----- > > drivers/net/wireless/ti/wl1251/spi.c | 33 ++++++++++++++++++--= -------- > > drivers/net/wireless/ti/wl1251/wl1251.h | 2 +- > > include/linux/wl12xx.h | 2 +- > > 6 files changed, 43 insertions(+), 28 deletions(-) > ... > > diff --git a/include/linux/wl12xx.h b/include/linux/wl12xx.h > > index b516b4f..a9c723b 100644 > > --- a/include/linux/wl12xx.h > > +++ b/include/linux/wl12xx.h > > @@ -49,7 +49,7 @@ enum { > > }; > > =20 > > struct wl1251_platform_data { > > - void (*set_power)(bool enable); > > + int power_gpio; > > /* SDIO only: IRQ number if WLAN_IRQ line is used, 0 for SDIO IRQs */ > > int irq; > > bool use_eeprom; > > --=20 >=20 > What a reason for not using regulator API here with GPIO-based > regulator? I think this pin is not used as power supply, but like an enable pin for low power states. Of course the regulator API could still be (mis?)used for this, but I think it would be the first linux device driver doing this. Note: I don't have wl1251 documentation. -- Sebastian --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBCAAGBQJSbXOhAAoJENju1/PIO/qaWF4P+QHuK97jolVl7yfy/U0+EUDs I71tbvIWvi3t1TryAUzpEbjQ3xOn4kcXiKC6lQd5Ugdeo1CYuiXcfFY7T1Vl0OZo YpWvEWT3qhi2Mfgmw07wL1WTcDqpzeYhDm65fbjSs2fjeSRH5baTyOk6UJuvXeWv H/n3fyeaRQBWKAjoURyzwodRMsvmWtVswgIFdghpfdctwLX2Rt2EJOPYlp9a+q60 tl52WLtPZecICcDmgSrncHeoaNeb9r1S6FYhTzTLmvnpPoyv5fW/cgqCflctoRbx THhYeohVHOTJ7sE/O9GGeOHHPcjQowhO1OX8LszsZboSR+fiWv71QwpzK3AzcZK4 Bbair8sd/obxklir1XwvT6KTAPX9J2Ws80dxNPwEzEFZJ2+kIUSDiHkHEqZk/erX IkNgQ1IAkpv/YzTHSm+TOkXlU7sAn5DxLerWx1rAG7Q4P14+neAsjazTkB/z42sT v2OxciLhXagecBnrYMfw6Tq6/KVJlq8J/3FKQuavxlg1n+N2u74PyBfe9EHoxELo ZRQAIqmixr9rAgsIQIdR0M2lF6ZFSANz9bny8WssfWyQ4pcATvaMkcebrg2hi/vb K526DlqDD2oxrSOIJW3mNu31UFx2MVGvybOnCh9KfneiqpX0ET07gmesr/yBRLW2 Cos9K3MESexvQzDiHWgr =7NT/ -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--