Return-path: Received: from mail-ve0-f173.google.com ([209.85.128.173]:39905 "EHLO mail-ve0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380Ab3JFUjK (ORCPT ); Sun, 6 Oct 2013 16:39:10 -0400 Received: by mail-ve0-f173.google.com with SMTP id cz12so3256838veb.4 for ; Sun, 06 Oct 2013 13:39:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1380234508-3121-1-git-send-email-k.eugene.e@gmail.com> <20131004234514.GA11128@garbanzo.do-not-panic.com> Date: Sun, 6 Oct 2013 22:39:09 +0200 Message-ID: (sfid-20131006_223925_147818_03BA1394) Subject: Re: [PATCH] wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware From: Eugene Krasnikov To: "Luis R. Rodriguez" Cc: John Linville , linux-wireless , wcn36xx@lists.infradead.org, wcn36xx@qca.qualcomm.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Luis, Warnings are valid! Thanx for pointing them. Will fix and resend the patch togather with ur regdb patch+warning fix. 2013/10/6 Eugene Krasnikov : > Hi Luis, > > Thanx for the patch. Although there is a one small comment: > >> +static void wcn_reg_notifier(struct wiphy *wiphy, >> + struct regulatory_request *request) >> +{ > > Function should be called wcn36xx_reg_notifier not wcn_reg_notifier. > Could you please change that? > > Also are you concerned about this warnings? > >> Nice! I test compiled with sparse enabled and got this: >> >> mcgrof@chalten ~/wireless-testing (git::master)$ make C=1 >> M=drivers/net/wireless/ath/wcn36xx/ >> CHECK drivers/net/wireless/ath/wcn36xx/main.c >> CC [M] drivers/net/wireless/ath/wcn36xx/main.o >> CHECK drivers/net/wireless/ath/wcn36xx/dxe.c >> CC [M] drivers/net/wireless/ath/wcn36xx/dxe.o >> CHECK drivers/net/wireless/ath/wcn36xx/txrx.c >> CC [M] drivers/net/wireless/ath/wcn36xx/txrx.o >> CHECK drivers/net/wireless/ath/wcn36xx/smd.c >> /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (4096 8) >> /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (512 8) >> /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (128 8) >> /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (8 8) >> /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (256 8) >> /home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (4096 8) > > What kind of config are you using to generate this warnings? -- Best regards, Eugene