Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:58670 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002Ab3J1Ghh convert rfc822-to-8bit (ORCPT ); Mon, 28 Oct 2013 02:37:37 -0400 Subject: Re: [PATCH 4/4] wl1251: spi: add device tree support Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <1382890469-25286-5-git-send-email-sre@debian.org> Date: Mon, 28 Oct 2013 01:37:34 -0500 Cc: Sebastian Reichel , Luciano Coelho , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Tony Lindgren , Russell King , "John W. Linville" , Felipe Balbi , Sachin Kamat , Greg Kroah-Hartman , Bill Pemberton , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Message-Id: (sfid-20131028_073755_817057_02A5C900) References: <1382890469-25286-1-git-send-email-sre@debian.org> <1382890469-25286-5-git-send-email-sre@debian.org> To: Sebastian Reichel Sender: linux-wireless-owner@vger.kernel.org List-ID: On Oct 27, 2013, at 11:14 AM, Sebastian Reichel wrote: > Add device tree support for the spi variant of wl1251 > and document the binding. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/net/wireless/ti,wl1251.txt | 36 ++++++++++++++++++++++ > drivers/net/wireless/ti/wl1251/spi.c | 23 ++++++++++---- > 2 files changed, 53 insertions(+), 6 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > new file mode 100644 > index 0000000..5f8a154 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > @@ -0,0 +1,36 @@ > +* Texas Instruments wl1251 controller > + > +The wl1251 chip can be connected via SPI or via SDIO. The linux > +kernel currently only supports device tree for the SPI variant. > + >From the binding I have no idea what this chip actually does, also we don't normally reference linux kernel support in bindings specs (so please remove it). However, what would expect the SDIO binding to look like? Or more specifically, how would you distinguish the SPI vs SDIO binding/connection? I'm wondering if the compatible should be something like "ti,wl1251-spi" and than the sdio can be "ti,wl1251-sdio" > +Required properties: > +- compatible : Should be "ti,wl1251" reg is not listed as a required prop. > +- interrupts : Should contain interrupt line > +- interrupt-parent : Should be the phandle for the interrupt > + controller that services interrupts for this device > +- vio-supply : phandle to regulator providing VIO > +- power-gpio : GPIO connected to chip's PMEN pin should be vendor prefixed: ti,power-gpio > +- For additional required properties on SPI, please consult > + Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Optional properties: > +- ti,use-eeprom : If found, configuration will be loaded from eeprom. can you be a bit more specific on what cfg will be loaded. Also, is this property a boolean, if so how do I know which eeprom the cfg is loaded from (is it one that is directly connected to the wl1251? > + > +Examples: > + > +&spi1 { > + wl1251_spi@0 { > + compatible = "ti,wl1251"; > + > + reg = <0>; > + spi-max-frequency = <48000000>; > + spi-cpol; > + spi-cpha; > + > + interrupt-parent = <&gpio2>; > + interrupts = <10 IRQ_TYPE_NONE>; /* gpio line 42 */ > + > + vio-supply = <&vio>; > + power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ > + }; > +}; -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation