Return-path: Received: from services.gouders.net ([141.101.32.176]:32908 "EHLO services.gouders.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756535Ab3J1ROY (ORCPT ); Mon, 28 Oct 2013 13:14:24 -0400 From: Dirk Gouders To: Johannes Berg Cc: Simon Wunderlich , linux-wireless@vger.kernel.org, Mathias Kretschmer , Linux Kernel Subject: Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation In-Reply-To: <1382970069.17956.23.camel@jlt4.sipsolutions.net> (Johannes Berg's message of "Mon, 28 Oct 2013 15:21:09 +0100") References: <1382472166-19563-1-git-send-email-sw@simonwunderlich.de> <1382970069.17956.23.camel@jlt4.sipsolutions.net> Date: Mon, 28 Oct 2013 18:14:42 +0100 Message-ID: (sfid-20131028_181440_434150_8088736A) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg writes: > On Tue, 2013-10-22 at 22:02 +0200, Simon Wunderlich wrote: >> The wext internal chandefs for ibss should be created using the >> cfg80211_chandef_create() functions. Otherwise the center_freq1 field >> will not be set and cfg80211_chandef_valid() will spit a warning and >> report the chandef as invalid when it should be used. > > I think > > commit f478f33a93f9353dcd1fe55445343d76b1c3f84a > Author: Bruno Randolf > Date: Thu Sep 26 16:55:28 2013 +0100 > > cfg80211: fix warning when using WEXT for IBSS > > > already fixed this. Your patch doesn't apply, but feel free to send me a > new one (for -next) converting to the creation helpers. I tested the above commit and it also fixes the problems I noticed here. Best regards, Dirk