Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:56478 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755513Ab3JPM41 (ORCPT ); Wed, 16 Oct 2013 08:56:27 -0400 From: Kalle Valo To: Michal Kazior CC: , Subject: Re: [PATCH 0/7] ath10k: fixes 2013-10-15 References: <1381858196-17000-1-git-send-email-michal.kazior@tieto.com> <8761sybbye.fsf@kamboji.qca.qualcomm.com> Date: Wed, 16 Oct 2013 15:56:22 +0300 In-Reply-To: <8761sybbye.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Tue, 15 Oct 2013 21:55:53 +0300") Message-ID: <87bo2p74sp.fsf@kamboji.qca.qualcomm.com> (sfid-20131016_145631_048927_9D6F6A11) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Michal Kazior writes: > >> This is a bunch of fixes I've had queued up for >> some time now. I was reluctant to send them >> without some additional checks and because some of >> the fixes are not ideal. At least we can get a >> discussion going if anything raises any serious >> concern. >> >> >> Michal Kazior (7): >> ath10k: prevent starting monitor without a vdev >> ath10k: add sanity checks for monitor management >> ath10k: fix endianess in prints >> ath10k: fix NSS reporting in RX >> ath10k: fix NULL deref upon early FW crash >> ath10k: fix device initialization routine >> ath10k: fix FW crashes on heavy TX on 10.1.389 AP FW > > I get few long line warnings: > > drivers/net/wireless/ath/ath10k/pci.c:1842: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/pci.c:1844: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/pci.c:1847: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/pci.c:1848: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/pci.c:1856: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/pci.c:1875: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/pci.c:1877: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/pci.c:1883: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/mac.c:2284: WARNING: line over 80 characters Michal, if it's ok for you I'll submit v2 of this patchset. I'll fix the long line warnings and also I do small cleanup to the warm reset code. -- Kalle Valo