Return-path: Received: from mail-ve0-f175.google.com ([209.85.128.175]:62522 "EHLO mail-ve0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855Ab3KTHzX (ORCPT ); Wed, 20 Nov 2013 02:55:23 -0500 Received: by mail-ve0-f175.google.com with SMTP id jx11so2421448veb.34 for ; Tue, 19 Nov 2013 23:55:23 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1384870413-5569-1-git-send-email-yeohchunyeow@gmail.com> Date: Wed, 20 Nov 2013 07:55:22 +0000 Message-ID: (sfid-20131120_085530_945385_ABBD0110) Subject: Re: [PATCH] wcn36xx: set self sta entry as HT capable From: Eugene Krasnikov To: Yeoh Chun-Yeow Cc: linux-wireless , John Linville , wcn36xx Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Most of these values are taken from wcn_band_2ghz Will try to remember: sta_params->ht_capable = 1 sta_params->tx_channel_width_set = 1 sta_params->lsig_txop_protection = 1 sta_params->max_ampdu_size = 3 // Might be wrong but let's have this value as a begining. sta_params->max_ampdu_density = 5 // Might be wrong but let's have this value as a begining. sta_params->max_amsdu_size = 0 sta_params->sgi_20Mhz = 1 sta_params->sgi_40mhz = 1 sta_params->green_field_capable = 1 sta_params->delayed_ba_support = 0 sta_params->dsss_cck_mode_40mhz = 1 On Wed, Nov 20, 2013 at 7:43 AM, Yeoh Chun-Yeow wrote: >> This function will set all of the following fields to default values: >> sta_params->ht_capable >> sta_params->tx_channel_width_set >> sta_params->lsig_txop_protection >> sta_params->max_ampdu_size >> sta_params->max_ampdu_density >> sta_params->max_amsdu_size >> sta_params->sgi_20Mhz >> sta_params->sgi_40mhz >> sta_params->green_field_capable >> sta_params->delayed_ba_support >> sta_params->dsss_cck_mode_40mhz > > > I am alright with that. But I am not sure about the default value of other > fields mentioned above. Are you able to provide that? > >> >> And then in wcn36xx_smd_set_sta_params it is called like this: >> wcn36xx_set_default_rates(&sta_params->supported_rates); >> wcn36xx_smd_set_sta_default_ht_params >> >> How does that sound? > > > --- > Chun-Yeow -- Best regards, Eugene