Return-path: Received: from mail-la0-f47.google.com ([209.85.215.47]:45511 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842Ab3K0Goj (ORCPT ); Wed, 27 Nov 2013 01:44:39 -0500 MIME-Version: 1.0 In-Reply-To: References: <1384119945-31213-1-git-send-email-felipe.contreras@gmail.com> <1384160932.14334.6.camel@jlt4.sipsolutions.net> <1384184624.14334.31.camel@jlt4.sipsolutions.net> <1384188067.14334.45.camel@jlt4.sipsolutions.net> <1384189227.14334.48.camel@jlt4.sipsolutions.net> <1384367422.14578.20.camel@jlt4.sipsolutions.net> Date: Wed, 27 Nov 2013 00:44:36 -0600 Message-ID: (sfid-20131127_074447_618743_CF55B969) Subject: Re: [PATCH v2] mac80211: add assoc beacon timeout logic From: Felipe Contreras To: Johannes Berg Cc: linux-wireless Mailing List , netdev , "John W. Linville" , "David S. Miller" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Nov 14, 2013 at 4:44 AM, Felipe Contreras wrote: > On Wed, Nov 13, 2013 at 12:30 PM, Johannes Berg > wrote: >> In any case, I'm not really comfortable connecting to an AP that we >> never ever receive beacons from. > > Well, we are *already* doing that for every driver, except the ones > that do IEEE80211_HW_NEED_DTIM_BEFORE_ASSOC, which are few. Since you didn't reply I'm going to arrive to the obvious conclusion; we *already* connect to APs even if we don't receive any beacons, my patch simply makes it consistent for the drivers that set IEEE80211_HW_NEED_DTIM_BEFORE_ASSOC. Therefore all your reasons to not apply the patch have been dismissed. -- Felipe Contreras