Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:7807 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907Ab3K0OsW (ORCPT ); Wed, 27 Nov 2013 09:48:22 -0500 From: Kalle Valo To: Michal Kazior CC: , Subject: Re: [PATCH v2 0/8] ath10k: pci fixes 2013-11-22 References: <1385125518-13461-1-git-send-email-michal.kazior@tieto.com> <1385384787-12470-1-git-send-email-michal.kazior@tieto.com> Date: Wed, 27 Nov 2013 16:48:17 +0200 In-Reply-To: <1385384787-12470-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Mon, 25 Nov 2013 14:06:19 +0100") Message-ID: <87txexgatq.fsf@kamboji.qca.qualcomm.com> (sfid-20131127_154825_025695_75D12A4B) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > Hi, > > ath10k didn't play well with other devices on a > shared irq line. This patchset fixes support for > shared legacy interrupts. > > Some rework was necessary because ath10k was using > disable_irq and CE irq masking (which is not > sufficient for shared interrupts). > > Since main irq handlers are now registered after > boot, BMI is now polling for CE updates. I haven't > observed any differences in boot speed. > > Also this plugs a leak I spotted during rework and > adds an option for testing different irq modes. > > v2: > * simplify ath10k_pci_irq_pending() > * combine memory leak fix patch with a > functionality decoupling (it's very closely > related) > * fix 'irq: nobody cared' > * change MSI/MSI-X disabling parameters > * some minor fixes & code shuffling to avoid > forward declarations > > > Michal Kazior (8): > ath10k: don't consume other's shared interrupts > ath10k: split up pci irq code > ath10k: don't use interrupts for BMI > ath10k: decouple ath10k_pci_start_ce() > ath10k: defer irq registration until hif start() > ath10k: extract functions for legacy irq handling > ath10k: re-add support for early fw indication > ath10k: allow explicit MSI/MSI-X disabling Thanks, all eight applied. -- Kalle Valo