Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:37051 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756020Ab3KHHG1 (ORCPT ); Fri, 8 Nov 2013 02:06:27 -0500 Cc: Eugene Krasnikov , "Luis R. Rodriguez" , "John W. Linville" , wcn36xx , linux-wireless , , "linux-kernel@vger.kernel.org" , , ath9k-devel , , From: Kalle Valo To: Joe Perches Subject: Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon References: <1383684000.4387.42.camel@joe-AO722> <1383760556.7940.28.camel@joe-AO722> <1383853221.9263.14.camel@joe-AO722> Date: Fri, 8 Nov 2013 09:06:19 +0200 In-Reply-To: <1383853221.9263.14.camel@joe-AO722> (Joe Perches's message of "Thu, 7 Nov 2013 11:40:21 -0800") Message-ID: <87bo1vcqz8.fsf@kamboji.qca.qualcomm.com> (sfid-20131108_080807_786049_7B0374E6) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Joe Perches writes: >> have a >> second round of convincing ath guys to change printing code. How does >> that sound? > > Luis? Kalle? Other Qualcomm/Atheros folk? I didn't quite get what you are asking from me. But for me most important is that the current debugging facilities from user's point of view don't change. I don't care if the code is in ath10k.ko or ath.ko, we are talking about ~100 lines of code anyway. > One of the nominal benefits of separating the ath_ > macros by subsystem was perf/tracing. Nominal? -- Kalle Valo