Return-path: Received: from smtprelay0164.hostedemail.com ([216.40.44.164]:55723 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754675Ab3KFRzz (ORCPT ); Wed, 6 Nov 2013 12:55:55 -0500 Message-ID: <1383760556.7940.28.camel@joe-AO722> (sfid-20131106_185615_670584_A288A8EA) Subject: Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon From: Joe Perches To: Eugene Krasnikov , "Luis R. Rodriguez" Cc: "John W. Linville" , wcn36xx , linux-wireless , netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" , ath5k-devel@lists.ath5k.org, ath9k-devel , ath10k@lists.infradead.org Date: Wed, 06 Nov 2013 09:55:56 -0800 In-Reply-To: References: <1383684000.4387.42.camel@joe-AO722> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2013-11-06 at 07:49 +0000, Eugene Krasnikov wrote: > Hm... when it comes to semicolon the patch seems to be good. When it > comes to dynamic debugging i think we should have a separate > discussion about that. > I personally like the whole idea about dynamic debug but if you want > to change it i would suggest to have some kind of framework for all > ath drivers(or maybe all wireless drivers). Because obviously you can > find common code in every driver that defines it's own debug > functions/debug levels and so on. Why not to make a framework with > standard API/levels? You need to bring that up with the Atheros folk. I've tried. The view seemed to be it was more trouble than it was worth.