Return-path: Received: from mail-we0-f172.google.com ([74.125.82.172]:45258 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751825Ab3LTIhg (ORCPT ); Fri, 20 Dec 2013 03:37:36 -0500 Received: by mail-we0-f172.google.com with SMTP id p61so2165064wes.31 for ; Fri, 20 Dec 2013 00:37:35 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <8AC12462F1AA0E4EA8FEB46307AAD6F650AAB122@nasanexd02f.na.qualcomm.com> References: <1384198356-427-1-git-send-email-rajeshc@qca.qualcomm.com> <1386077130.4393.21.camel@jlt4.sipsolutions.net> <1386145204.4284.4.camel@jlt4.sipsolutions.net> <1386145241.4284.5.camel@jlt4.sipsolutions.net> <8AC12462F1AA0E4EA8FEB46307AAD6F650AAB068@nasanexd02f.na.qualcomm.com> <8AC12462F1AA0E4EA8FEB46307AAD6F650AAB122@nasanexd02f.na.qualcomm.com> From: "Luis R. Rodriguez" Date: Fri, 20 Dec 2013 00:37:15 -0800 Message-ID: (sfid-20131220_093739_714511_EDCFE2C0) Subject: Re: [PATCHv3] cfg80211: add support for frequency interference event To: "BAHINI, Henri" Cc: "Chauhan, Rajesh" , Johannes Berg , linux-wireless , "Malinen, Jouni" , "Johnson, Jeff" , "Chang, Leo" , "Luo, Xun" , "Thalappil, Sameer" , "Hussain, Arif" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Dec 20, 2013 at 12:30 AM, BAHINI, Henri wrote: > Please do educate us a bit! > We were not aware of the requirement that all patches contributions to the cfg/nl have to be for driver > that are already up streamed. Its not and this will depend on the driver / approach / and intent but it does help. > As for our effort for upstreaming our driver, we should take this out of this context since there > are factors driving this that are completely orthogonal to this discussion. That's true but it makes it harder for provide examples of the patches you are introducing. Typically we just remove code that's unused. If you have no intent on upstreaming then what's the point of doing tons of review and consideration on API that we deeply care of for userspace? The patch is debatable as-is already, I've provided my feedback on it before and if you don't get good feedback from others and also if some of this is because you are not upstreaming then I'm trying to highlight for you that perhaps that should be of a little more importance to you. Luis