Return-path: Received: from moutng.kundenserver.de ([212.227.17.9]:53460 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752575Ab3LCKoA (ORCPT ); Tue, 3 Dec 2013 05:44:00 -0500 Message-ID: <529DB5E9.2080003@lri.fr> (sfid-20131203_114404_848042_3AF669D0) Date: Tue, 03 Dec 2013 11:43:53 +0100 From: Nicolas Cavallari MIME-Version: 1.0 To: Johannes Berg CC: linux-wireless@vger.kernel.org, j@w1.fi Subject: Re: [RFC] cfg80211/mac80211: drop GTK-protected unicast IP packets References: <1386010316-2540-1-git-send-email-johannes@sipsolutions.net> <529DA7FB.6020600@lri.fr> <1386063957.4393.4.camel@jlt4.sipsolutions.net> <529DB560.40805@lri.fr> In-Reply-To: <529DB560.40805@lri.fr> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/12/2013 11:41, Nicolas Cavallari wrote: > On 03/12/2013 10:45, Johannes Berg wrote: >> On Tue, 2013-12-03 at 10:44 +0100, Nicolas Cavallari wrote: >>> On 02/12/2013 19:51, Johannes Berg wrote: >>>> + if (!ipv4_is_multicast(ip.hdr4.daddr)) >>>> + return -1; >>> >>> So broadcasting to e.g. 192.168.255.255 is now forbidden ? >> >> Please, read the patch :) > > I read the patch further. ipv4_is_multicast only checks if the > address is in 224/4, so this patch makes __ieee80211_data_to_8023 > returns 0 for 224.0.0.0 to 239.255.255.255, and returns -1 for > everything else, including the 255.255.255.255, 192.168.255.255 and > other limited broadcast addresses Err, i mean directed broadcast addresses.