Return-path: Received: from mail-qe0-f42.google.com ([209.85.128.42]:35544 "EHLO mail-qe0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755184Ab3LPSeb (ORCPT ); Mon, 16 Dec 2013 13:34:31 -0500 Received: by mail-qe0-f42.google.com with SMTP id b4so4281924qen.15 for ; Mon, 16 Dec 2013 10:34:31 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1387142056-21850-1-git-send-email-twpedersen@gmail.com> <1387142056-21850-2-git-send-email-twpedersen@gmail.com> From: Thomas Pedersen Date: Mon, 16 Dec 2013 10:34:10 -0800 Message-ID: (sfid-20131216_193434_931870_A4CDB084) Subject: Re: [PATCH 2/3] mac80211: reset TSF to 0 when joining a mesh To: Sergey Ryazanov Cc: Johannes Berg , open80211s , linux-wireless , Thomas Pedersen Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Dec 16, 2013 at 4:33 AM, Sergey Ryazanov wrote: > Hello Thomas, > > 2013/12/16 Thomas Pedersen : >> diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c >> index 330d1f7..1174157 100644 >> --- a/net/mac80211/mesh.c >> +++ b/net/mac80211/mesh.c >> @@ -802,6 +802,8 @@ int ieee80211_start_mesh(struct ieee80211_sub_if_data *sdata) >> return -ENOMEM; >> } >> >> + /* next beacon will be DTIM-1, so TSF=0 was DTIM=0 */ >> + drv_set_tsf(local, sdata, 0); >> ieee80211_bss_info_change_notify(sdata, changed); >> >> netif_carrier_on(sdata->dev); > > What happen with AP interface on the same radio if we configure mesh > portal? Clients could be confused by such TSF jump. Like Johannes said; either the driver supports per-vif TSF, or well, it doesn't. Anyway wouldn't clients reset their own TSF when the new beacon is received? Thomas