Return-path: Received: from mail-ea0-f178.google.com ([209.85.215.178]:45829 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753897Ab3LaQoI convert rfc822-to-8bit (ORCPT ); Tue, 31 Dec 2013 11:44:08 -0500 References: <1388427307-8691-1-git-send-email-Julia.Lawall@lip6.fr> <1388427307-8691-2-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 (1.0) In-Reply-To: <1388427307-8691-2-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=us-ascii Message-Id: (sfid-20131231_174432_436122_0ECFDE6A) Cc: Ivo van Doorn , "kernel-janitors@vger.kernel.org" , Helmut Schaa , "John W. Linville" , "linux-wireless@vger.kernel.org" , "users@rt2x00.serialmonkey.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Gertjan van Wingerde Subject: Re: [PATCH 1/11] rt2x00: use ether_addr_equal_64bits Date: Tue, 31 Dec 2013 17:44:03 +0100 To: Julia Lawall Sender: linux-wireless-owner@vger.kernel.org List-ID: Sent from my iPad > On 30 dec. 2013, at 19:14, Julia Lawall wrote: > > From: Julia Lawall > > Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be > used when each argument is an array within a structure that contains at > least two bytes of data beyond the array. > > The structures involved are: > ieee80211_bar defined in include/linux/ieee80211.h and > rt2x00_bar_list_entry defined in drivers/net/wireless/rt2x00/rt2x00.h. > > This was done using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall Acked-by: Gertjan van Wingerde > > --- > The semantic patch used is rather long and can be found in message 0 of > this patch series. > > drivers/net/wireless/rt2x00/rt2x00dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c > index 00c3fae..2bde672 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00dev.c > +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c > @@ -565,10 +565,10 @@ static void rt2x00lib_rxdone_check_ba(struct rt2x00_dev *rt2x00dev, > > #undef TID_CHECK > > - if (!ether_addr_equal(ba->ra, entry->ta)) > + if (!ether_addr_equal_64bits(ba->ra, entry->ta)) > continue; > > - if (!ether_addr_equal(ba->ta, entry->ra)) > + if (!ether_addr_equal_64bits(ba->ta, entry->ra)) > continue; > > /* Mark BAR since we received the according BA */ >