MIME-Version: 1.0
In-Reply-To: <1389787494-7361-10-git-send-email-michal.kazior@tieto.com>
References: <1389787494-7361-1-git-send-email-michal.kazior@tieto.com>
	<1389787494-7361-10-git-send-email-michal.kazior@tieto.com>
Date: Thu, 16 Jan 2014 13:04:03 +0200
Message-ID: <CAB3XZEe0yM2F4C5DbWE+BjDVn92Sv_=k5EiUpokZjF1QugdSWw@mail.gmail.com> (sfid-20140116_120407_757857_D0FCEAC5)
Subject: Re: [RFC 9/9] mac80211: implement multi-interface CSA
From: Eliad Peller <eliad@wizery.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-wireless-owner@vger.kernel.org

On Wed, Jan 15, 2014 at 2:04 PM, Michal Kazior <michal.kazior@tieto.com> wrote:
> This implements a fairly simple multi-interface
> CSA. It doesn't support multiple channel
> contexts so it doesn't support multi-channel.
>
> Once a CSA is started other CSA requests are
> denied until the first one is completed. A single
> CSA may affect multiple interfaces. CSA can happen
> only if it all target CSA chandefs are compatible
> and it affects all interfaces are sharing a single
> channel context exclusively.
>
> A new worker is introduced: csa_complete_work
> which is used to account per-interface countdowns
> and issue the actual channel switch after last
> interface completes its CSA.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> ---
[...]

>
> +static int ieee80211_ap_beacon_presp_backup(struct ieee80211_sub_if_data *sdata)
> +{
> +       struct beacon_data *beacon;
> +       struct probe_resp *probe_resp;
> +
> +       beacon = sdata_dereference(sdata->u.ap.beacon, sdata);
> +       if (beacon) {
> +               sdata->u.ap.prev_beacon = kmemdup(beacon, sizeof(beacon) +
> +                                                 beacon->head_len +
> +                                                 beacon->tail_len, GFP_KERNEL);
> +               if (!sdata->u.ap.prev_beacon)
> +                       return -ENOMEM;
> +       }
> +
you must also update the pointers here...

Eliad.