Return-path: Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:53745 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbaAHJdJ (ORCPT ); Wed, 8 Jan 2014 04:33:09 -0500 Message-ID: <52CD1B52.5000101@broadcom.com> (sfid-20140108_103329_524464_2A857583) Date: Wed, 8 Jan 2014 10:33:06 +0100 From: Arend van Spriel MIME-Version: 1.0 To: Chen-Yu Tsai CC: linux-sunxi , Hans de Goede , Julian Calaby , linux-wireless , Olliver Schinagl , Subject: Re: [linux-sunxi] Firmware for Bluetooth (and wifi) References: <52A040CE.5040706@schinagl.nl> <52A09B5B.70800@schinagl.nl> <52B17973.1000608@broadcom.com> <52B19F38.7060503@redhat.com> <52B1CA51.4010202@broadcom.com> <52BD68BA.3080304@broadcom.com> <52CD12D4.5030008@broadcom.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/08/2014 10:23 AM, Chen-Yu Tsai wrote: > On Wed, Jan 8, 2014 at 4:56 PM, Arend van Spriel wrote: >> On 12/27/2013 01:36 PM, Chen-Yu Tsai wrote: >>>>>>> Working tree: >>>>>>> >>>>>>> https://github.com/wens/linux/tree/wip/sunxi-next-wifi >>>>>>> >>>>>>> Comments welcome :) >>>>> >>>>> No comment, but: Nice work! >>> Thanks. BTW, who should submit the patch? :) >> >> Hi Chen-Yu >> >> I will submit the patch today. > > Great! > > I added device tree support for brcmfmac SDIO devices, > to be able to specify external out-of-band interrupts. > Unfortunately it's not working. I get the following output: > > brcmfmac: brcmf_sdbrcm_bus_rxctl: resumed on timeout > brcmfmac: brcmf_fil_cmd_data: Failed err=-110 > brcmfmac: brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -110 > brcmfmac: brcmf_bus_start: failed: -110 > brcmfmac: brcmf_sdbrcm_probe: dongle is not responding This is typeical behaviour when interrupt is not picked up. > brcmfmac: brcmf_sdio_probe: device attach failed > brcmfmac: brcmf_ops_sdio_probe: F2 error, probe failed -19... > > Should we add device tree support for the brcmf platform driver, > so we can enable power, clocks, etc. before the SDIO driver is probed? How does the device-tree change for oob interrupt look like. > Not sure if this is the right way. Maxime mentioned on IRC that some > mmc host drivers take a vmmc regulator property. > > Currently I am using rfkill-gpio to do this. But brcmfmac also > registers an rfkill of its own. Not sure what you mean here. The only thing I am aware of is that cfg80211 registers brcmfmac as wifi transmitter in the rfkill framework, which is unrelated to gpio's. > Also, I have bluetooth working. Turns out it was a wrong pinctrl > setting in my dt. For those who want to try: > > Get and compile brcm_patchram_plus from > http://code.google.com/p/broadcom-bluetooth/ > > Run brcm_patchram_plus --patchram bcm20710a1.hcd --no2bytes /dev/ttyS1 > and hciattach /dev/ttyS1 > > If brcm_patchram_plus hangs, you may need to reset the controller > by blocking then unblocking the bluetooth rfkill switch. > > I pushed all my work out already. Here's the link again: > > https://github.com/wens/linux/tree/wip/sunxi-next-wifi I will take a look. Gr. AvS