Return-path: Received: from mail-la0-f53.google.com ([209.85.215.53]:42007 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbaAMIkI (ORCPT ); Mon, 13 Jan 2014 03:40:08 -0500 Received: by mail-la0-f53.google.com with SMTP id e16so2156510lan.12 for ; Mon, 13 Jan 2014 00:40:06 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1388390871-3932-1-git-send-email-marek.puzyniak@tieto.com> Date: Mon, 13 Jan 2014 09:40:06 +0100 Message-ID: (sfid-20140113_094014_208216_15326DD5) Subject: Re: [PATCH] ath10k: disable STA KICKOUT in FW From: Marek Puzyniak To: Yeoh Chun-Yeow Cc: ath10k@lists.infradead.org, "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 9 January 2014 10:09, Yeoh Chun-Yeow wrote: > Hi, Marek Hi, > > Do you mind to share which firmware that you are using? I am using FW from: https://github.com/kvalo/ath10k-firmware/blob/master/ap/firmware-2.bin_10.1.467-1 > I have tried your patch and this is set accordingly in an the AP (set > param 13). But once the associated STA is leaving, > WMI_PEER_STA_KICKOUT_EVENTID is still received. > > [ 145.060000] ath10k: wmi pdev set param 13 value 0 > ....... > [ 148.560000] ath10k: wmi vdev id 0x0 set param 8 value 1 > [ 148.560000] ath10k: wmi peer create vdev_id 0 peer_addr 04:f0:21:0c:a5:44 > [ 148.560000] ath10k: wmi peer assoc vdev 0 addr 04:f0:21:0c:a5:44 > [ 149.040000] ath10k: wmi event debug mesg len 44 > [ 209.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 210.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > > FYI, I am using firmware version 999.999.0.636 > > ethtool -i wlan0 > driver: ath10k_pci > firmware-version: 999.999.0.636 > > Thanks > > Regards, > Chun-Yeow Marek > > > On Wed, Jan 8, 2014 at 6:40 PM, Marek Puzyniak wrote: >> On 2 January 2014 13:41, Yeoh Chun-Yeow wrote: >>> >>> On Dec 30, 2013 4:08 PM, "Marek Puzyniak" wrote: >>>> >>>> Currently ath10k is not using STA KICKOUT firmware functionality. >>>> In order to avoid unwanted FW events this functionality should be >>>> disabled when not used. >>> >>> What are unwanted FW events? >> >> WMI_PEER_STA_KICKOUT_EVENT which indicates lack of activity from >> associated STA for specified period of time. >> >>> >>> ---- >>> Chun-Yeow >> Marek >>> >>>> Signed-off-by: Marek Puzyniak >>>> --- >>>> drivers/net/wireless/ath/ath10k/mac.c | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c >>>> b/drivers/net/wireless/ath/ath10k/mac.c >>>> index 5b45f3a..93416ab 100644 >>>> --- a/drivers/net/wireless/ath/ath10k/mac.c >>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c >>>> @@ -2292,11 +2292,20 @@ static int ath10k_add_interface(struct >>>> ieee80211_hw *hw, >>>> } >>>> >>>> if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { >>>> + u32 param_id; >>>> + >>>> ret = ath10k_peer_create(ar, arvif->vdev_id, vif->addr); >>>> if (ret) { >>>> ath10k_warn("Failed to create peer for AP: %d\n", >>>> ret); >>>> goto err_vdev_delete; >>>> } >>>> + >>>> + param_id = ar->wmi.pdev_param->sta_kickout_th; >>>> + >>>> + /* Disable STA KICKOUT functionality in FW */ >>>> + ret = ath10k_wmi_pdev_set_param(ar, param_id, 0); >>>> + if (ret) >>>> + ath10k_warn("Failed to disable STA KICKOUT\n"); >>>> } >>>> >>>> if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { >>>> -- >>>> 1.8.1.2 >>>> >>>> >>>> _______________________________________________ >>>> ath10k mailing list >>>> ath10k@lists.infradead.org >>>> http://lists.infradead.org/mailman/listinfo/ath10k