Return-path: Received: from mail-ob0-f172.google.com ([209.85.214.172]:60367 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117AbaAZOfn (ORCPT ); Sun, 26 Jan 2014 09:35:43 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Sun, 26 Jan 2014 15:35:42 +0100 Message-ID: (sfid-20140126_153548_838055_7D455ACE) Subject: Re: [PATCH v4 1/2] b43: fix the wrong assignment of status.freq in b43_rx() From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: ZHAO Gang Cc: Stefano Brivio , Johannes Berg , Jonas Gorski , Luca Coelho , "John W. Linville" , b43-dev , "linux-wireless@vger.kernel.org" , Stable Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2014/1/17 ZHAO Gang : > Use the right function to update frequency value. > > If rx skb is probe response or beacon, the wrong frequency value can > cause problem that bss info can't be updated when it should be. Zhao: this fix is great. My development machine was running some ancient distro with kernel 2.6.22, so I couldn't test it earlier. For a long time I got problem with finding AP on channel 13. I reported it in: cfg80211: use DS or HT operation IEs to determine BSS channel" I did 10 tests *without* your patch. wpa_supplicant had to scan 43, 33, 7, 2, 46, 12, 7, 32, 6, 6 times to find my AP on channel 13. With your patch wpa_supplicant finds it in scanning results after the first try! Thanks a lot for finding and fixing it! [0] http://lists.infradead.org/pipermail/b43-dev/2013-March/003003.html