Return-path: Received: from mail-la0-f49.google.com ([209.85.215.49]:36575 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbaAEGmW (ORCPT ); Sun, 5 Jan 2014 01:42:22 -0500 Received: by mail-la0-f49.google.com with SMTP id er20so8876709lab.8 for ; Sat, 04 Jan 2014 22:42:20 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1388870653-3507-1-git-send-email-chaitanya.mgit@gmail.com> References: <1388870653-3507-1-git-send-email-chaitanya.mgit@gmail.com> Date: Sun, 5 Jan 2014 08:42:17 +0200 Message-ID: (sfid-20140105_074243_949359_C998ABEF) Subject: Re: [PATCH] mac80211: SMPS: Fix the overwrite of rx_chains in the interface loop. From: Emmanuel Grumbach To: Chaitanya T K Cc: Johannes Berg , linux-wireless Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Jan 4, 2014 at 11:24 PM, Chaitanya T K wrote: > The interface loop identifies the no of static and dynamic > smps chains, but overwrites their values across the VIF's > (assuming there are more than one, in my case its AP and STA > loopback), so the driver might not intimated about this update > of SMPS mode, is the value is same. > > So inform driver for every VIF. > > For Ex: STA's SMPS state is changed, but in the loop AP appears > at the last, SMPS state of AP is unchanged hence not intimated > to the driver. > > Signed-off-by: Chaitanya T K > --- But the dynamic / static chains number is a property of the channel context. If you have several vifs on the same channel context, the maximum number of dynamic / static chains will be assigned to the channel context. In short, I think that mac80211 already does the job of taking all the parameters into account and putting the right value into the channel context? I don't really see what bug you are trying to solve - could you please tell us exactly what is your configuration? What SMPS do you have for each interface and what dynamic / static chains settings does mac80211 end up with?