Return-path: Received: from s3.sipsolutions.net ([144.76.43.152]:43011 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755191AbaAFPMN (ORCPT ); Mon, 6 Jan 2014 10:12:13 -0500 Message-ID: <1389021111.5891.21.camel@jlt4.sipsolutions.net> (sfid-20140106_161238_067964_2BA1A922) Subject: Re: [PATCH v3.5 10/19] mac8011: slight optimization of addr compare From: Johannes Berg To: Ding Tianhong Cc: "John W. Linville" , "David S. Miller" , linux-wireless@vger.kernel.org, Netdev , "linux-kernel@vger.kernel.org" Date: Mon, 06 Jan 2014 16:11:51 +0100 In-Reply-To: <52BC15C8.2080400@huawei.com> References: <52BC15C8.2080400@huawei.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2013-12-26 at 19:40 +0800, Ding Tianhong wrote: > Use the possibly more efficient ether_addr_equal > to instead of memcmp. This is a slow-path, I don't think that's really worth it. It kinda makes sense, but relies on the struct mac_address allocation for alignment and the fact that there are no other members in that struct, so it seems to me that this ought to also add some alignment attributes? johannes