Message-ID: <1389021322.5891.25.camel@jlt4.sipsolutions.net> (sfid-20140106_161531_707494_B7415662)
Subject: Re: [PATCH] mac80211: Fix the buffer length in debugfs for smps
From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Date: Mon, 06 Jan 2014 16:15:22 +0100
In-Reply-To: <CABPxzY+yP1N1xLBHcVvMss_E=+2_3M95bQCEaxbkzvF+wbtnCQ@mail.gmail.com> (sfid-20140106_160529_519013_7D101F00)
References: <1388869583-2767-1-git-send-email-chaitanya.mgit@gmail.com>
	 <1389019739.5891.16.camel@jlt4.sipsolutions.net>
	 <CABPxzY+yP1N1xLBHcVvMss_E=+2_3M95bQCEaxbkzvF+wbtnCQ@mail.gmail.com>
	 (sfid-20140106_160529_519013_7D101F00)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Mon, 2014-01-06 at 20:35 +0530, Krishna Chaitanya wrote:
> On Mon, Jan 6, 2014 at 8:18 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Sun, 2014-01-05 at 02:36 +0530, Chaitanya T K wrote:
> >> This was blocking sending SMPS action frames
> >> through debugfs.
> >
> > I don't see any issue here, explain.
> >
> > johannes
> >
> buflen includes the new line character as well, hence the comparison
> strncmp fails for all combiantions.
> 
> echo "static" > ieee80211/phyX/netdev\:wlanX/smps
> Then
> 
> buf=static\n
> buflen=7
> 
> But the comparison is with "static" which doesn't include "\n"
> hence the comparison fails.

Err, ok, so you can just do "echo -n static", right?

And then your patch breaks the way it currently works, which is about
the worst you can do.

johannes