Return-path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:37421 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754827AbaAFPcf (ORCPT ); Mon, 6 Jan 2014 10:32:35 -0500 Received: by mail-wi0-f170.google.com with SMTP id hq4so2877555wib.3 for ; Mon, 06 Jan 2014 07:32:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1389021322.5891.25.camel@jlt4.sipsolutions.net> References: <1388869583-2767-1-git-send-email-chaitanya.mgit@gmail.com> <1389019739.5891.16.camel@jlt4.sipsolutions.net> <1389021322.5891.25.camel@jlt4.sipsolutions.net> From: Krishna Chaitanya Date: Mon, 6 Jan 2014 21:02:13 +0530 Message-ID: (sfid-20140106_163238_421834_DBF63FCA) Subject: Re: [PATCH] mac80211: Fix the buffer length in debugfs for smps To: Johannes Berg Cc: linux-wireless Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jan 6, 2014 at 8:45 PM, Johannes Berg wrote: > On Mon, 2014-01-06 at 20:35 +0530, Krishna Chaitanya wrote: >> On Mon, Jan 6, 2014 at 8:18 PM, Johannes Berg wrote: >> > On Sun, 2014-01-05 at 02:36 +0530, Chaitanya T K wrote: >> >> This was blocking sending SMPS action frames >> >> through debugfs. >> > >> > I don't see any issue here, explain. >> > >> > johannes >> > >> buflen includes the new line character as well, hence the comparison >> strncmp fails for all combiantions. >> >> echo "static" > ieee80211/phyX/netdev\:wlanX/smps >> Then >> >> buf=static\n >> buflen=7 >> >> But the comparison is with "static" which doesn't include "\n" >> hence the comparison fails. > > Err, ok, so you can just do "echo -n static", right? > > And then your patch breaks the way it currently works, which is about > the worst you can do. > Ok, if one works other fails. So instead why cant we use strlen(local_string) instead of using buflen(remote). That way we can make sure we only compare the characters we need and leave out the extra ones.