Return-path: Received: from mail-we0-f181.google.com ([74.125.82.181]:52190 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbaAEHnr (ORCPT ); Sun, 5 Jan 2014 02:43:47 -0500 Received: by mail-we0-f181.google.com with SMTP id x55so14918483wes.12 for ; Sat, 04 Jan 2014 23:43:46 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1388870653-3507-1-git-send-email-chaitanya.mgit@gmail.com> From: Krishna Chaitanya Date: Sun, 5 Jan 2014 13:13:25 +0530 Message-ID: (sfid-20140105_084409_603251_52718105) Subject: Re: [PATCH] mac80211: SMPS: Fix the overwrite of rx_chains in the interface loop. To: Emmanuel Grumbach Cc: Johannes Berg , linux-wireless Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: >> Same applies if the driver doesn't support channel contexts. hw_config >> will be called with the correct local->smps_mode based on the number >> of channels required by each one of the vifs? >> I don't see why only the last vif will be taken into account: the loop >> computes the maximum number of antenna requires by *all* the vifs. >> What am I missing here? Got it. Ours was a special loopback case where 2 VIF's talk to each other (one AP and one STA), so we had a problem there. Please ignore this patch. Thanks Emmanuel.