Return-path: Received: from mail-la0-f53.google.com ([209.85.215.53]:46576 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbaA2NUW (ORCPT ); Wed, 29 Jan 2014 08:20:22 -0500 Received: by mail-la0-f53.google.com with SMTP id e16so1438739lan.40 for ; Wed, 29 Jan 2014 05:20:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87ppnbdj6j.fsf@kamboji.qca.qualcomm.com> References: <1390999696-8895-1-git-send-email-marek.puzyniak@tieto.com> <87ppnbdj6j.fsf@kamboji.qca.qualcomm.com> Date: Wed, 29 Jan 2014 14:20:13 +0100 Message-ID: (sfid-20140129_142038_541302_E9D2895C) Subject: Re: [PATCH] ath10k: configure access category for arp From: Marek Puzyniak To: Kalle Valo Cc: ath10k@lists.infradead.org, "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 29 January 2014 14:14, Kalle Valo wrote: > Marek Puzyniak writes: > >> ARP frames exchange does not work properly for UAPSD enabled AP. >> ARP requests which arrives with access category 0 are processed >> by network stack and send back with access category 0. FW changes >> access category to 6. This is causing problems when UAPSD associated >> STA is sleeping after has sent ARP request. Configure ARP access >> category in FW to best effort (0) solves this problem. ARP frames >> will be send with access category 0. >> >> Simplify arp ac override functionality by removing redundant entry in >> pdev param maping table. There should be only one entry in pdev param >> map but enum has different name for different FW. >> >> Signed-off-by: Marek Puzyniak > > I had a conflict when I applied this to ath-next-test. Please check that > I didn't break anything: > > https://github.com/kvalo/ath/commit/2e006642b3aad6a5fb91f9e560a2bbcdf74aa049 It looks ok. > >> + ret = ath10k_wmi_pdev_set_param(ar, >> + ar->wmi.pdev_param->arp_ac_override, 0); >> + if (ret) { >> + ath10k_warn("could not init WMI_PDEV_PARAM_ARP_AC_OVERRIDE (%d)\n", >> + ret); > > I also modified this warning message to follow the style used elsewhere > in the driver. > > -- > Kalle Valo