Return-path: Received: from szxga01-in.huawei.com ([119.145.14.64]:40643 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755110AbaAHCye (ORCPT ); Tue, 7 Jan 2014 21:54:34 -0500 Message-ID: <52CCBDBD.6050906@huawei.com> (sfid-20140108_035457_891180_0C02E339) Date: Wed, 8 Jan 2014 10:53:49 +0800 From: Ding Tianhong MIME-Version: 1.0 To: Johannes Berg , "John W. Linville" , "David S. Miller" , , Netdev , "linux-kernel@vger.kernel.org" Subject: [PATCH v3.6 10/19] mac8011: slight optimization of addr compare Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: Use the possibly more efficient ether_addr_equal to instead of memcmp. Cc: Johannes Berg Cc: John W. Linville Cc: David Miller Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Wang Weidong Signed-off-by: Ding Tianhong --- net/mac80211/iface.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 7aa9f9d..a4f9812 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1497,8 +1497,8 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local, bool used = false; list_for_each_entry(sdata, &local->interfaces, list) { - if (memcmp(local->hw.wiphy->addresses[i].addr, - sdata->vif.addr, ETH_ALEN) == 0) { + if (ether_addr_equal(local->hw.wiphy->addresses[i].addr, + sdata->vif.addr)) { used = true; break; } @@ -1558,8 +1558,7 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local, val += inc; list_for_each_entry(sdata, &local->interfaces, list) { - if (memcmp(tmp_addr, sdata->vif.addr, - ETH_ALEN) == 0) { + if (ether_addr_equal(tmp_addr, sdata->vif.addr)) { used = true; break; } -- 1.8.0