Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:45565 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbaAaF2E (ORCPT ); Fri, 31 Jan 2014 00:28:04 -0500 Date: Fri, 31 Jan 2014 06:29:21 +0100 From: Greg KH To: Olivier Langlois Cc: Larry.Finger@lwfinger.net, linville@tuxdriver.com, chaoming_li@realsil.com.cn, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/2] retry hw init when it fails Message-ID: <20140131052921.GA27202@kroah.com> (sfid-20140131_062827_584096_73CFDC82) References: <1391145383-18652-1-git-send-email-olivier@trillion01.com> <1391145383-18652-2-git-send-email-olivier@trillion01.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1391145383-18652-2-git-send-email-olivier@trillion01.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jan 31, 2014 at 12:16:23AM -0500, Olivier Langlois wrote: > rtl_ps_enable_nic() is called from loops that will loop until this function returns true or a > maximum number of retries is performed. > > hw_init() returns non-zero on error. In that situation return false to > restore the original design intent to retry hw init when it fails. > > Signed-off-by: Olivier Langlois > --- > drivers/net/wireless/rtlwifi/ps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. Same goes for aptch 1/2 as well...