Return-path: Received: from s3.sipsolutions.net ([144.76.43.152]:36350 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754497AbaBUKME (ORCPT ); Fri, 21 Feb 2014 05:12:04 -0500 Message-ID: <1392977516.4346.47.camel@jlt4.sipsolutions.net> (sfid-20140221_111209_444785_B269BB42) Subject: Re: [PATCH 1/4] cfg80211: regulatory, introduce DFS CAC time From: Johannes Berg To: Janusz Dziedzic Cc: linux-wireless@vger.kernel.org, "Luis R. Rodriguez" , John Linville Date: Fri, 21 Feb 2014 11:11:56 +0100 In-Reply-To: (sfid-20140221_110909_899698_3CFDCAEF) References: <1392231266-28479-1-git-send-email-janusz.dziedzic@tieto.com> <1392972748.4346.37.camel@jlt4.sipsolutions.net> <1392976535.4346.46.camel@jlt4.sipsolutions.net> (sfid-20140221_110909_899698_3CFDCAEF) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2014-02-21 at 11:09 +0100, Janusz Dziedzic wrote: > On 21 February 2014 10:55, Johannes Berg wrote: > > On Fri, 2014-02-21 at 10:47 +0100, Janusz Dziedzic wrote: > >> On 21 February 2014 09:52, Johannes Berg wrote: > >> > On Wed, 2014-02-12 at 19:54 +0100, Janusz Dziedzic wrote: > >> > > >> >> +++ b/include/net/regulatory.h > >> >> @@ -155,6 +155,7 @@ struct ieee80211_reg_rule { > >> >> struct ieee80211_freq_range freq_range; > >> >> struct ieee80211_power_rule power_rule; > >> >> u32 flags; > >> >> + u32 dfs_cac_ms; > >> >> }; > >> > > >> > Does that really have to be per channel? That's a significant investment > >> > into bss size since we have a lot of channel structs. > >> > > >> This seems easiest way to handle ETSI VHT80/40 case for channels with > >> different CAC time (eg): > >> VHT80: > >> - 116 (60s) > >> - 120 (600s) > >> - 124 (600s) > >> - 128 (600s) > >> > >> VHT40/HT40: > >> - 132 (600s) > >> - 136 (60s) > > > > Huh, but you don't distinguish between channel widths in this whole > > patchset? > > > In patch cfg80211: DFS get CAC time from regulatory I check whole > chandef and get max channel cac value. Oh, right, I misunderstood your other email. johannes