Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:61234 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbaBJJAp (ORCPT ); Mon, 10 Feb 2014 04:00:45 -0500 Subject: Re: [PATCH] net: rfkill-regulator: Add devicetree support. Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: "Dr. H. Nikolaus Schaller" In-Reply-To: <1392020862.4128.1.camel@jlt4.sipsolutions.net> Date: Mon, 10 Feb 2014 09:54:34 +0100 Cc: Marek Belisko , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rob@landley.net, "John W. Linville" , David Miller , grant.likely@linaro.org, NeilBrown Brown , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, LKML , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Message-Id: (sfid-20140210_100111_166726_B5E645C0) References: <1391802529-29861-1-git-send-email-marek@goldelico.com> (sfid-20140207_204900_539631_47DCB6B7) <1392020862.4128.1.camel@jlt4.sipsolutions.net> To: Johannes Berg Sender: linux-wireless-owner@vger.kernel.org List-ID: Am 10.02.2014 um 09:27 schrieb Johannes Berg: > On Fri, 2014-02-07 at 20:48 +0100, Marek Belisko wrote: > >> +#define RFKILL_TYPE_ALL (0) >> +#define RFKILL_TYPE_WLAN (1) >> +#define RFKILL_TYPE_BLUETOOTH (2) >> +#define RFKILL_TYPE_UWB (3) >> +#define RFKILL_TYPE_WIMAX (4) >> +#define RFKILL_TYPE_WWAN (5) >> +#define RFKILL_TYPE_GPS (6) >> +#define RFKILL_TYPE_FM (7) >> +#define RFKILL_TYPE_NFC (8) > > This seems like a bad idea since there's an enum elsewhere in userspace > API already. Yes, you are right. It is defined in include/uapi/linux/rfkill.h Tnx, Nikolaus