MIME-Version: 1.0
In-Reply-To: <1392883153.5073.4.camel@jlt4.sipsolutions.net>
References: <1392226988-3878-1-git-send-email-janusz.dziedzic@tieto.com>
	<CAB=NE6VEmUr5rVhaeShdJQomhhQ3VeDcHaqeHo0jGNaWKtMwyQ@mail.gmail.com>
	<CAFED-jn0AfGVqJVFfeu6Pke2UBh-+nnRrhdVM-4acYHn9WdSjQ@mail.gmail.com>
	<CAB=NE6UR3yQOSZr7NXA4kO2hKre0zBsmK9H1MTYZ=9Wh_=9AtA@mail.gmail.com>
	<CALhHN=qc7m7oce6aiiNfpW5wUc7ypy2E+0TmYsKNth5_s5FpxQ@mail.gmail.com>
	<1392882691.5073.3.camel@jlt4.sipsolutions.net>
	<CALhHN=owY-xYOmieHUeDpmSXqJir2VrmfxM8H3zjo0mVvM3GQg@mail.gmail.com>
	<1392883153.5073.4.camel@jlt4.sipsolutions.net>
Date: Thu, 20 Feb 2014 09:03:07 +0100
Message-ID: <CALhHN=rPZqBJiOHnT4O32FH1JkCSxBYY7gQ1m6RDnnHC9stySQ@mail.gmail.com> (sfid-20140220_090313_336539_62CB9646)
Subject: Re: [PATCH] crda: handle AUTO bw setting in db2rd
From: Janusz Dziedzic <janusz.dziedzic@tieto.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	Janusz Dziedzic <janusz.dziedzic@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-wireless-owner@vger.kernel.org

On 20 February 2014 08:59, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Thu, 2014-02-20 at 08:57 +0100, Janusz Dziedzic wrote:
>
>> >> Yes, seems we should send this even this is 0.
>> >> Next for old kernel, all channels where BW=0 will be HT20 only.
>> >
>> > Is that really a good idea?
>> >
>> > Maybe crda should just get the logic to determine maximum bandwidth,
>> > like you did in the kernel, and then we can even revert the kernel code
>> > again?
>> >
>> Yes, this is possible to calculate this in crda (or even set this manually).
>
> Ok. Would that help older kernels? How would we handle genregdb.awk?
>
In case of older kernels we will fail (end_freq - start_freq < bw) with -EINVAL.
So, bw=0 (cfg calculation) seems like best idea - will work with new
and old kernels.

BR
Janusz