Return-path: Received: from mail-ve0-f175.google.com ([209.85.128.175]:36481 "EHLO mail-ve0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbaB0Ns3 (ORCPT ); Thu, 27 Feb 2014 08:48:29 -0500 Received: by mail-ve0-f175.google.com with SMTP id oy12so3822052veb.34 for ; Thu, 27 Feb 2014 05:48:29 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87ob1sg50c.fsf@kamboji.qca.qualcomm.com> References: <1392197866-1261-1-git-send-email-yeohchunyeow@gmail.com> <877g8rxgyf.fsf@kamboji.qca.qualcomm.com> <87ob1sg50c.fsf@kamboji.qca.qualcomm.com> Date: Thu, 27 Feb 2014 21:48:28 +0800 Message-ID: (sfid-20140227_144833_711643_A17EC0E2) Subject: Re: [PATCH] ath10k: set the mactime of ieee80211_rx_status From: Yeoh Chun-Yeow To: Kalle Valo Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Feb 27, 2014 at 7:38 PM, Kalle Valo wrote: > Yeoh Chun-Yeow writes: > >>> Why? Where do you need tsf exactly? And what bug are you actually fixing >>> here? >> >> There are two type of configuration modes that require local TSF, IBSS >> and mesh for operation and also monitor mode. >> >> For IBSS, it is use for merging of BSSID (mac address) with same SSID >> name, but currently this is taking care by the following "ugly" patch. >> http://lists.infradead.org/pipermail/ath10k/2014-February/001159.html >> >> Mesh mode needs this for more accurate synchronization purpose. >> >> Besides, the monitor mode requires this to add extra piece of >> information in radiotap header for local TSF. >> >>> Do we get some regressions because of proving only a 32 bit TSF? Which >>> one is better, provide a 32-bit TSF or not at all? >> >> 32-bit is not good. It could cause problem when inter-operate with >> other non-ath10k drivers with 64-bit local TSF. > > Yeah, I understand that. But my question is will we create regressions > if I apply this patch which provides only 32-bit TSF? I guess not as we > haven't provided TSF at all before, but I would like to be sure. > >> The better is that we can get the 64-bit local TSF. providing high TSF >> and low TSF as found in "struct wmi_comb_phyerr_rx_hd". Is this >> possible with current FW? > > I'm not familiar with the firmware so I sent a question to the firmware > team about this. Great, appreciate if the FW team can take a look on this. Hope to hear from you again on this. ---- Chun-Yeow