Return-path: Received: from s3.sipsolutions.net ([144.76.43.152]:49592 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbaBXMXt (ORCPT ); Mon, 24 Feb 2014 07:23:49 -0500 Message-ID: <1393244624.4190.8.camel@jlt4.sipsolutions.net> (sfid-20140224_132351_635714_0370A337) Subject: Re: [PATCH v1 1/6] mac80211: move flag IEEE80211_TX_CTL_ASSIGN_SEQ into info->control.flags From: Johannes Berg To: Thomas Huehn Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, nbd@nbd.name Date: Mon, 24 Feb 2014 13:23:44 +0100 In-Reply-To: <1393164527-13800-2-git-send-email-thomas@net.t-labs.tu-berlin.de> References: <1393164527-13800-1-git-send-email-thomas@net.t-labs.tu-berlin.de> <1393164527-13800-2-git-send-email-thomas@net.t-labs.tu-berlin.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, 2014-02-23 at 15:08 +0100, Thomas Huehn wrote: > Flag IEEE80211_TX_CTL_ASSIGN_SEQ is only used within the tx path while > ieee80211_tx_info->control is valid. Therefore this patch moves this flag > from info->flags structure into the info->control.flags and renames it to > IEEE80211_TX_CTRL_ASSIGN_SEQ. I'm not convinced this patch is correct, so you need to convince me. What happens to software-retry frames? They probably *shouldn't* get a new seqno, but if the driver doesn't modify the SKB (say because hardware/firmware assigns it) then this is certainly not right. johannes