Return-path: Received: from s3.sipsolutions.net ([144.76.43.152]:59783 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752426AbaBTHvl (ORCPT ); Thu, 20 Feb 2014 02:51:41 -0500 Message-ID: <1392882691.5073.3.camel@jlt4.sipsolutions.net> (sfid-20140220_085145_289634_43FFD485) Subject: Re: [PATCH] crda: handle AUTO bw setting in db2rd From: Johannes Berg To: Janusz Dziedzic Cc: "Luis R. Rodriguez" , Janusz Dziedzic , linux-wireless , "John W. Linville" Date: Thu, 20 Feb 2014 08:51:31 +0100 In-Reply-To: (sfid-20140220_082755_205713_3661CC86) References: <1392226988-3878-1-git-send-email-janusz.dziedzic@tieto.com> (sfid-20140220_082755_205713_3661CC86) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2014-02-20 at 08:27 +0100, Janusz Dziedzic wrote: > On 19 February 2014 23:00, Luis R. Rodriguez wrote: > > On Tue, Feb 18, 2014 at 10:12 PM, Janusz Dziedzic > > wrote: > >> 2014-02-19 1:33 GMT+01:00 Luis R. Rodriguez : > >>> On Wed, Feb 12, 2014 at 9:43 AM, Janusz Dziedzic > >>> wrote: > >>>> Handle AUTO bandwidth setting in db2rd. > >>>> Don't add NL80211_ATTR_FREQ_RANGE_MAX_BW attribute > >>>> in case of AUTO bw calculation. > >>>> > >>>> Signed-off-by: Janusz Dziedzic > >>> > >>> Please elaborate more on this. Who deals with the automatic math on > >>> the bandwidth? > >>> > >> cfg80211, > >> > >> Please check patch: > >> cfg80211: regulatory introduce maximum bandwidth calculation > > > > OK, so we don't send the max bandwidth attribute now, what about > > support for older kernels? > > > Yes, seems we should send this even this is 0. > Next for old kernel, all channels where BW=0 will be HT20 only. Is that really a good idea? Maybe crda should just get the logic to determine maximum bandwidth, like you did in the kernel, and then we can even revert the kernel code again? johannes