Return-path: Received: from mx-relay04-dus.antispameurope.com ([94.100.134.204]:39057 "EHLO mx-relay04-dus.antispameurope.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754138AbaBQTMA convert rfc822-to-8bit (ORCPT ); Mon, 17 Feb 2014 14:12:00 -0500 From: "Kretschmer, Mathias" To: David Miller CC: "arend@broadcom.com" , "sw@simonwunderlich.de" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" Subject: RE: [net-next v2 3/3] cfg80211: add MPLS and 802.21 classification Date: Mon, 17 Feb 2014 19:11:05 +0000 Message-ID: (sfid-20140217_201210_828161_47465D94) References: <1392656174-14791-4-git-send-email-sw@simonwunderlich.de> <5302474B.6090609@broadcom.com> <20140217.140653.1309552047403078220.davem@davemloft.net> In-Reply-To: <20140217.140653.1309552047403078220.davem@davemloft.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > > Thought so, as well. But it seems that skb->protocol is not properly > > set when the packet originates from a packet socket. And in our case > > we cannot set it to a fixed etherType in the bind() call since we use > > three different etherTypes on the same socket. > > So many things break if the skb->protocol isn't set correctly that I would > consider such SKBs mal-formed. Agreed. > You can specify the protocol number in the msghdr passed into the send. Will take a look. Thx. Need to check if there is also a way to set the protocol number when using TX_RINGs, where we use one send() call to signal the kernel that a bunch of frames (with potentially different protocol numbers) is ready for consumption.