Return-path: Received: from mail-wg0-f43.google.com ([74.125.82.43]:58227 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbaBSW3j (ORCPT ); Wed, 19 Feb 2014 17:29:39 -0500 Received: by mail-wg0-f43.google.com with SMTP id a1so872294wgh.22 for ; Wed, 19 Feb 2014 14:29:38 -0800 (PST) Message-ID: <5305304B.5050004@gmail.com> (sfid-20140219_232943_245486_88E4A921) Date: Wed, 19 Feb 2014 22:29:31 +0000 From: Malcolm Priestley MIME-Version: 1.0 To: Joe Perches CC: gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 4/4] staging: vt6656: Remove typedef enum _CONTEXT_TYPE References: <1392846993.20211.15.camel@canaries64-MCP7A> <1392848134.24844.16.camel@joe-AO722> In-Reply-To: <1392848134.24844.16.camel@joe-AO722> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 19/02/14 22:15, Joe Perches wrote: > On Wed, 2014-02-19 at 21:56 +0000, Malcolm Priestley wrote: >> Replace with enum >> assign as u8 type. > [] >> diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h > [] >> @@ -180,7 +180,7 @@ struct vnt_usb_send_context { >> struct sk_buff *pPacket; >> struct urb *pUrb; >> unsigned int uBufLen; >> - CONTEXT_TYPE Type; >> + u8 type; > > This doesn't really save any space in the struct. > You might move it immediately before or after bBoolInUse. > >> struct ethhdr sEthHeader; >> void *Next; >> bool bBoolInUse; > > No, but there are dead members in the structure that need removing. sEthHeader and Next are dead