Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:6598 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbaCYGwT (ORCPT ); Tue, 25 Mar 2014 02:52:19 -0400 From: Kalle Valo To: Dan Carpenter CC: , Subject: Re: [PATCH v2] ath10k: add soft/hard firmware crash option to simulate_fw_crash References: <20140313082431.10798.10888.stgit@potku.adurom.net> <87pplih81g.fsf@kamboji.qca.qualcomm.com> <20140321143737.GA5140@mwanda> Date: Tue, 25 Mar 2014 08:52:14 +0200 In-Reply-To: <20140321143737.GA5140@mwanda> (Dan Carpenter's message of "Fri, 21 Mar 2014 17:37:38 +0300") Message-ID: <8738i64voh.fsf@kamboji.qca.qualcomm.com> (sfid-20140325_075223_655712_05BD9891) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Dan Carpenter writes: >> drivers/net/wireless/ath/ath10k/debug.c:500 ath10k_write_simulate_fw_crash() error: strncmp() '"hard"' too small (5 vs 32) >> drivers/net/wireless/ath/ath10k/debug.c:497 ath10k_write_simulate_fw_crash() error: strncmp() '"soft"' too small (5 vs 32) >> >> I wanted to use strncmp() instead of strcmp(), but I'm not sure what to >> do here. In my opinion it's guaranteed that the string "hard" is null >> terminated, so it shouldn't matter even if strlen("soft") (5) is less >> than sizeof(buf) (32), right? Or am I missing something here? >> > > I am on vacation until next week. I didn't think these particular > emails went out automatically. Actually that's true. Fengguang's bot sends me a build report after every build and I saw these warnings in that report. > Anyway, I have changed this in the latest smatch but it will take some > months for the kbuild bot to update. > > http://repo.or.cz/w/smatch.git/commitdiff/f10f27a7612c5b1e69b5d9080a0194d012beb6aa > > I'll take a closer look next week. Thanks! -- Kalle Valo