Return-path: Received: from mail-pd0-f170.google.com ([209.85.192.170]:45628 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbaCIB6Z (ORCPT ); Sat, 8 Mar 2014 20:58:25 -0500 Received: by mail-pd0-f170.google.com with SMTP id v10so5648026pde.29 for ; Sat, 08 Mar 2014 17:58:24 -0800 (PST) Message-ID: <531BCABD.6030000@converseincode.com> (sfid-20140309_025924_625842_317F6482) Date: Sat, 08 Mar 2014 17:58:21 -0800 From: Behan Webster MIME-Version: 1.0 To: Sergei Antonov , pageexec@freemail.hu CC: John Linville , Johannes Berg , davem@davemloft.net, linux-wireless , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Woodhouse , =?UTF-8?B?SmFuLVNpbW9uIE3DtmxsZXI=?= , =?UTF-8?B?Vmluw61jaQ==?= =?UTF-8?B?dXMgVGludGk=?= , Mark Charlebois Subject: Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211 References: <1394177091.4653.1.camel@jlt4.sipsolutions.net> <1394241960-1764-1-git-send-email-behanw@converseincode.com> <531B934C.31666.37555A14@pageexec.freemail.hu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/08/14 15:00, Sergei Antonov wrote: > On 8 March 2014 23:01, PaX Team wrote: >> On 8 Mar 2014 at 21:29, Sergei Antonov wrote: >> >>>> - memset(&aead_req, 0, sizeof(aead_req)); >>>> + char aead_req_data[sizeof(struct aead_request) + >>>> + crypto_aead_reqsize(tfm) + >>>> + CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR; >> ^^^^^^^^^^^^^^^^^^^^ >> wouldn't the underlined attribute ensure the required alignment? > Yes. Sorry, I overlooked it. > > I would remove unneeded CRYPTO_MINALIGN and get the alignment from the > target structure: > char aead_req_data[sizeof(struct aead_request) + > crypto_aead_reqsize(tfm)] > __attribute__((__aligned__(__alignof__(struct aead_request)))); Even better. Will resubmit. Behan -- Behan Webster behanw@converseincode.com