Return-path: Received: from mail.candelatech.com ([208.74.158.172]:54282 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbaCYPPS (ORCPT ); Tue, 25 Mar 2014 11:15:18 -0400 Message-ID: <53319D65.4090907@candelatech.com> (sfid-20140325_161524_249742_1A7E0727) Date: Tue, 25 Mar 2014 08:14:45 -0700 From: Ben Greear MIME-Version: 1.0 To: Michal Kazior CC: Kalle Valo , linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [PATCH 1/3] ath10k: Add debugging for tx-credits usage. References: <1395428150-31996-1-git-send-email-greearb@candelatech.com> <871txr7svw.fsf@kamboji.qca.qualcomm.com> <53306239.2020006@candelatech.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/25/2014 12:27 AM, Michal Kazior wrote: > On 24 March 2014 17:50, Ben Greear wrote: >> On 03/24/2014 04:21 AM, Michal Kazior wrote: >>> On 24 March 2014 12:12, Kalle Valo wrote: >> >>>>> - status = ath10k_htc_send(htc, ATH10K_HTC_EP_0, skb); >>>>> + status = ath10k_htc_send(htc, ATH10K_HTC_EP_0, skb, __LINE__); >>>> >>>> Using line numbers in debug messages is very cumbersome. Some people >>>> cherry pick patches, have their own changes and whatnot which will make >>>> it more difficult to read the debug logs. Isn't there any better way to >>>> do this? >>> >>> I would prefer to explicitly wait for tx credit replenishment in >>> ath10k_wmi_cmd_send() after a command is sent instead of all these >>> prints. This way you can get a full call trace if it times out. >> >> Would that be a performance problem (by effectively allowing only a single >> item to be sent to the firmware at any given time?) > > The only thing that may suffer here is wmi mgmt tx but I wouldn't > consider that performance critical. In that case, why use credits at all? Thanks, Ben > > > Michał > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Ben Greear Candela Technologies Inc http://www.candelatech.com