Return-path: Received: from s3.sipsolutions.net ([144.76.43.152]:55392 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbaCJU1u (ORCPT ); Mon, 10 Mar 2014 16:27:50 -0400 Message-ID: <1394483266.30155.1.camel@jlt4.sipsolutions.net> (sfid-20140310_212754_790069_B887CB73) Subject: Re: [PATCH 2/3] mac80211: include ieee80211_local in chanctx From: Johannes Berg To: Michal Kazior Cc: linux-wireless@vger.kernel.org Date: Mon, 10 Mar 2014 22:27:46 +0200 In-Reply-To: <1394191196-6425-2-git-send-email-michal.kazior@tieto.com> (sfid-20140307_122524_327332_7B691FCF) References: <1394191196-6425-1-git-send-email-michal.kazior@tieto.com> <1394191196-6425-2-git-send-email-michal.kazior@tieto.com> (sfid-20140307_122524_327332_7B691FCF) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2014-03-07 at 12:19 +0100, Michal Kazior wrote: > Channel contexts are implicitly bound to hw > already so make it possible to dereference it > through the channel context itself. > > This will make it possible to reduce number of > arguments for chanctx-related functions. I don't really see much point in this, is there ever anything where we really get only a channel context and don't already have the local pointer? With interfaces, at least, we need it because we can get an interface through e.g. do_stop or do_open, so we don't have an easy way to reference local, but here? I don't think our functions have so many arguments that it's worth putting a pointer into the struct instead. johannes